[ethmac] To bug or not to bug.

[Illan Glasner <IGlasner@mrv.com>]

    Just a small comment base on some of the latest post.

if you are all plan to use or already using the code don;t you think it is
time you also write a good test bench and not rely on reading the code with
your eye and hopefully don;t miss something ?

have a nice day

   Illan


-----Original Message-----
From: lim_mg@yahoo.com [mailto:lim_mg@yahoo.com]
Sent: Friday, February 21, 2003 9:13 AM
To: ethmac@opencores.org
Subject: Re: [ethmac] rxaddrcheck


thanks for clarification, i missed the fact that RxAbort is checked on 2 
cycles. i also made a mistake in my comment about your example on 
receivecontrol, your original post is correct.
my sincere apologies.


----- Original Message ----- 
From: yisonglin@s...  
To: ethmac@o...  
Date: Fri, 21 Feb 2003 09:39:52 -0100 
Subject: Re: [ethmac] rxaddrcheck 

> 
> 
> I don't think so. 
> 
> There are 2 RxClk per byte.So when bytecounter=7,RxAddressInvalid 
> is 
> asserted by the first RxClk,RxAbort is asserted by the 2nd RxClk. 
> 
> UnicastOK is updated 2 times per byte.I think it not need to do 
> so,though it will not lead to error.I prefer to check only once per 
> byte. 
> 
> BTW:I don't think it should be 48'h0080C4000801 in the example I 
> describled in my last post.Would you explain it in detail? 
> 
> ----- Original Message ----- 
> From: lim_mg@y... 
> To: ethmac@o... 
> Date: Fri, 7 Feb 2003 08:00:00 -0100 
> Subject: [ethmac] rxaddrcheck 
> 
> > 
> > 
> > just wonder if RxAbort is updated correctly in 
> eth_rxaddrcheck: 
> > 
> > RxAddressInvalid depends on UnicastOK which is finally updated 
> when 
> > ByteCnt is 7, so RxAbort should only be updated when ByteCnt 
> is 8 
> > and 
> > not 7. 
> > 
> > ..... 
> > assign RxAddressInvalid = ~(UnicastOK | BroadcastOK | 
> MulticastOK | 
> > r_Pro); 
> > ..... 
> > ..... 
> >   else if(RxAddressInvalid & ByteCntEq7 & RxCheckEn) 
> >     RxAbort <= #Tp 1'b1; 
> > ..... 
> > ..... 
> >   if(RxCheckEn & ByteCntEq7) 
> >     UnicastOK <= #Tp ( RxData[7:0] == MAC[7:0])   & 
> > UnicastOK; 
> > ..... 
> > ..... 
> > 
> 
--
To unsubscribe from ethmac mailing list please visit
http://www.opencores.org/mailinglists.shtml
--
To unsubscribe from ethmac mailing list please visit http://www.opencores.org/mailinglists.shtml