Security update for yubico-piv-tool SUSE Patch security@suse.de SUSE Security Team SUSE-SU-2019:1123-1 Final 1 1 2019-04-30T16:04:51Z current 2019-04-30T16:04:51Z 2019-04-30T16:04:51Z cve-database/bin/generate-cvrf.pl 2017-02-24T01:00:00Z Security update for yubico-piv-tool This update for yubico-piv-tool fixes the following issues: Security issues fixed: - Fixed an buffer overflow and an out of bounds memory read in ykpiv_transfer_data(), which could be triggered by a malicious token. (CVE-2018-14779, bsc#1104809, YSA-2018-03) - Fixed an buffer overflow and an out of bounds memory read in _ykpiv_fetch_object(), which could be triggered by a malicious token. (CVE-2018-14780, bsc#1104811, YSA-2018-03) The CVRF data is provided by SUSE under the Creative Commons License 4.0 with Attribution (CC-BY-4.0). SUSE-2019-1123,SUSE-SLE-Module-Basesystem-15-2019-1123 Copyright SUSE LLC under the Creative Commons License 4.0 with Attribution (CC-BY-4.0) https://www.suse.com/support/update/announcement/2019/suse-su-20191123-1/ Link for SUSE-SU-2019:1123-1 https://lists.suse.com/pipermail/sle-security-updates/2019-April/005418.html E-Mail link for SUSE-SU-2019:1123-1 https://www.suse.com/support/security/rating/ SUSE Security Ratings https://bugzilla.suse.com/1104809 SUSE Bug 1104809 https://bugzilla.suse.com/1104811 SUSE Bug 1104811 https://www.suse.com/security/cve/CVE-2018-14779/ SUSE CVE CVE-2018-14779 page https://www.suse.com/security/cve/CVE-2018-14780/ SUSE CVE CVE-2018-14780 page SUSE Linux Enterprise Module for Basesystem 15 libykcs11-1-1.5.0-3.3.33 libykcs11-devel-1.5.0-3.3.33 libykpiv-devel-1.5.0-3.3.33 libykpiv1-1.5.0-3.3.33 yubico-piv-tool-1.5.0-3.3.33 libykcs11-1-1.5.0-3.3.33 as a component of SUSE Linux Enterprise Module for Basesystem 15 libykcs11-devel-1.5.0-3.3.33 as a component of SUSE Linux Enterprise Module for Basesystem 15 libykpiv-devel-1.5.0-3.3.33 as a component of SUSE Linux Enterprise Module for Basesystem 15 libykpiv1-1.5.0-3.3.33 as a component of SUSE Linux Enterprise Module for Basesystem 15 yubico-piv-tool-1.5.0-3.3.33 as a component of SUSE Linux Enterprise Module for Basesystem 15 A buffer overflow issue was discovered in the Yubico-Piv 1.5.0 smartcard driver. The file lib/ykpiv.c contains the following code in the function `ykpiv_transfer_data()`: {% highlight c %} if(*out_len + recv_len - 2 > max_out) { fprintf(stderr, "Output buffer to small, wanted to write %lu, max was %lu.", *out_len + recv_len - 2, max_out); } if(out_data) { memcpy(out_data, data, recv_len - 2); out_data += recv_len - 2; *out_len += recv_len - 2; } {% endhighlight %} -- it is clearly checked whether the buffer is big enough to hold the data copied using `memcpy()`, but no error handling happens to avoid the `memcpy()` in such cases. This code path can be triggered with malicious data coming from a smartcard. CVE-2018-14779 SUSE Linux Enterprise Module for Basesystem 15:libykcs11-1-1.5.0-3.3.33 SUSE Linux Enterprise Module for Basesystem 15:libykcs11-devel-1.5.0-3.3.33 SUSE Linux Enterprise Module for Basesystem 15:libykpiv-devel-1.5.0-3.3.33 SUSE Linux Enterprise Module for Basesystem 15:libykpiv1-1.5.0-3.3.33 SUSE Linux Enterprise Module for Basesystem 15:yubico-piv-tool-1.5.0-3.3.33 low 7.2 AV:L/AC:L/Au:N/C:C/I:C/A:C To install this SUSE Security Update use the SUSE recommended installation methods like YaST online_update or "zypper patch". https://www.suse.com/support/update/announcement/2019/suse-su-20191123-1/ https://www.suse.com/security/cve/CVE-2018-14779.html CVE-2018-14779 https://bugzilla.suse.com/1104809 SUSE Bug 1104809 An out-of-bounds read issue was discovered in the Yubico-Piv 1.5.0 smartcard driver. The file lib/ykpiv.c contains the following code in the function `_ykpiv_fetch_object()`: {% highlight c %} if(sw == SW_SUCCESS) { size_t outlen; int offs = _ykpiv_get_length(data + 1, &outlen); if(offs == 0) { return YKPIV_SIZE_ERROR; } memmove(data, data + 1 + offs, outlen); *len = outlen; return YKPIV_OK; } else { return YKPIV_GENERIC_ERROR; } {% endhighlight %} -- in the end, a `memmove()` occurs with a length retrieved from APDU data. This length is not checked for whether it is outside of the APDU data retrieved. Therefore the `memmove()` could copy bytes behind the allocated data buffer into this buffer. CVE-2018-14780 SUSE Linux Enterprise Module for Basesystem 15:libykcs11-1-1.5.0-3.3.33 SUSE Linux Enterprise Module for Basesystem 15:libykcs11-devel-1.5.0-3.3.33 SUSE Linux Enterprise Module for Basesystem 15:libykpiv-devel-1.5.0-3.3.33 SUSE Linux Enterprise Module for Basesystem 15:libykpiv1-1.5.0-3.3.33 SUSE Linux Enterprise Module for Basesystem 15:yubico-piv-tool-1.5.0-3.3.33 low 2.1 AV:L/AC:L/Au:N/C:P/I:N/A:N To install this SUSE Security Update use the SUSE recommended installation methods like YaST online_update or "zypper patch". https://www.suse.com/support/update/announcement/2019/suse-su-20191123-1/ https://www.suse.com/security/cve/CVE-2018-14780.html CVE-2018-14780 https://bugzilla.suse.com/1104809 SUSE Bug 1104809 https://bugzilla.suse.com/1104811 SUSE Bug 1104811